Closed
Conversation
Greptile SummaryAdded comprehensive QUIC teardown lifecycle tests covering session and endpoint cleanup behaviors. Includes shared test helpers (
Tests follow existing patterns and use proper assertions. Note: session.close() tests will fail on current main due to known bug where Confidence Score: 4/5
Important Files Changed
Last reviewed commit: 7ddd0d1 |
Author
1 similar comment
Author
Adds shared test helpers (checkQuic, defaultCerts, createQuicPair) and 17 subtests covering session close, session destroy, and endpoint close/destroy behavior. session.close() hangs on current main because handle.gracefulClose() never fires kFinishClose back to JS. Tests assert the documented contract and will fail until that is fixed. Refs: nodejs#60122 Refs: nodejs#60309 Refs: nodejs#57119
mannie-exe
force-pushed
the
quic/test-teardown-lifecycle
branch
from
7ddd0d1 to
46d7cdd
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
test/common/quic/helpers.mjs:checkQuic,defaultCerts,createQuicPair(similar to quic: For streams allow ReadableStream as body nodejs/node#60237)test/parallel/test-quic-session-close.mjs: 5 subteststest/parallel/test-quic-session-destroy.mjs: 5 subteststest/parallel/test-quic-endpoint-close.mjs: 7 subtestssession.close()is broken right now;handle.gracefulClose()never fireskFinishCloseback to JS soawait session.closedhangs forever. Tests are written to the documented contract so they'll fail on current main, which is the point.session.destroy()works fine.Refs: nodejs#60309, nodejs#57119
nodejs#60122 covers 2.3.1, 2.3.3, and 1.2